Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TiDB serverless branching in Vercel integration #14835

Merged
merged 16 commits into from
Oct 10, 2023

Conversation

xuanyu66
Copy link

@xuanyu66 xuanyu66 commented Sep 14, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2023
@xuanyu66 xuanyu66 added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. translation/no-need No need to translate this PR. labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 14, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
@ran-huang ran-huang self-requested a review September 15, 2023 06:02
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 15, 2023
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2023
github-actions bot pushed a commit to xuanyu66/pingcap-docs-website-scaffold that referenced this pull request Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
1. Select **Cluster** as your connection type.
2. Enable TiDB Serverless Branching in the TiDB Cloud Vercel integration workflow.

After you push changes to GitHub repository, Vercel will trigger a preview deployment. And then TiDB Cloud integration will automatically create a TiDB Serverless branch for the branch and set environment variables. The detailed steps are as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After you push changes to GitHub repository, Vercel will trigger a preview deployment. And then TiDB Cloud integration will automatically create a TiDB Serverless branch for the branch and set environment variables. The detailed steps are as follows:
After you push changes to the GitHub repository, Vercel will trigger a preview deployment. Then, TiDB Cloud integration will automatically create a TiDB Serverless branch for the GitHub branch and set environment variables. The detailed steps are as follows:

tidb-cloud/integrate-tidbcloud-with-vercel.md Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预览里这张图片看起来有点模糊

tidb-cloud/integrate-tidbcloud-with-vercel.md Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-vercel.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 09:00:37.18044932 +0000 UTC m=+508003.148037355: ☑️ agreed by ran-huang.
  • 2023-09-19 07:42:09.280742878 +0000 UTC m=+589695.248330937: ☑️ agreed by qiancai.

@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 59e05cb into release-7.1 Oct 10, 2023
@ran-huang ran-huang deleted the vercel-branching branch October 10, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants