From d788c98ca38d1851236aaf7297788c06e60160c5 Mon Sep 17 00:00:00 2001 From: Grace Cai Date: Tue, 20 Feb 2024 15:32:48 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: xixirangrang --- configure-placement-rules.md | 4 ++-- tiflash/troubleshoot-tiflash.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure-placement-rules.md b/configure-placement-rules.md index c8efec54dbb34..20269ca9b7f28 100644 --- a/configure-placement-rules.md +++ b/configure-placement-rules.md @@ -77,7 +77,7 @@ The Placement Rules feature is enabled by default in v5.0 and later versions of enable-placement-rules = true ``` -In this way, PD enables this feature after the cluster is successfully bootstrapped and generates corresponding rules according to the `max-replicas`, `location-labels`, and `isolation-level` configurations: +In this way, PD enables this feature after the cluster is successfully bootstrapped and generates corresponding rules according to the [`max-replicas`](/pd-configuration-file.md#max-replicas), [`location-labels`](/pd-configuration-file.md#location-labels), and [`isolation-level`](/pd-configuration-file.md#isolation-level) configurations: {{< copyable "" >}} @@ -121,7 +121,7 @@ pd-ctl config placement-rules disable > **Note:** > -> After disabling Placement Rules, PD uses the original `max-replicas`, `location-labels`, and `isolation-level` configurations. The modification of rules (when Placement Rules is enabled) will not update these two configurations in real time. In addition, all the rules that have been configured remain in PD and will be used the next time you enable Placement Rules. +> After disabling Placement Rules, PD uses the original `max-replicas`, `location-labels`, and `isolation-level` configurations. The modification of rules (when Placement Rules is enabled) will not update these three configurations in real time. In addition, all the rules that have been configured remain in PD and will be used the next time you enable Placement Rules. ### Set rules using pd-ctl diff --git a/tiflash/troubleshoot-tiflash.md b/tiflash/troubleshoot-tiflash.md index 29416fee1937d..71909281dea45 100644 --- a/tiflash/troubleshoot-tiflash.md +++ b/tiflash/troubleshoot-tiflash.md @@ -74,7 +74,7 @@ This is because TiFlash is in an abnormal state caused by configuration errors o > **Note:** > - > - When [Placement Rules](/configure-placement-rules.md) are enabled and multiple rules exist, the previously configured `max-replicas`, `location-labels`, and `isolation-level` no longer take effect. To adjust the replica policy, use the interface related to Placement Rules. + > - When [Placement Rules](/configure-placement-rules.md) are enabled and multiple rules exist, the previously configured [`max-replicas`](/pd-configuration-file.md#max-replicas), [`location-labels`](/pd-configuration-file.md#location-labels), and [`isolation-level`](/pd-configuration-file.md#isolation-level) no longer take effect. To adjust the replica policy, use the interface related to Placement Rules. > - When [Placement Rules](/configure-placement-rules.md) are enabled and only one default rule exists, TiDB will automatically update this default rule when `max-replicas`, `location-labels`, or `isolation-level` configurations are changed. 6. Check whether the remaining disk space of the machine (where `store` of the TiFlash node is) is sufficient. By default, when the remaining disk space is less than 20% of the `store` capacity (which is controlled by the `low-space-ratio` parameter), PD cannot schedule data to this TiFlash node.