Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

fix typo in exists_with_error #731

Closed
wants to merge 1 commit into from
Closed

fix typo in exists_with_error #731

wants to merge 1 commit into from

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added, or deleted? (Required)

fix a typo in exists_with_error to close #719.

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2021
@Liuxiaozhen12 Liuxiaozhen12 added the translation/no-need The changes in this PR don't need to be translated. label Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 19, 2021
@Liuxiaozhen12 Liuxiaozhen12 added the needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. label Jul 19, 2021
@lance6716
Copy link
Contributor

very sorry that developers have made typo 😂 but I think this typo should be fixed DM first. Considering the compatibility, we may choose not fix it

cc @glorv @GMHDBJD @lichunzhu @Ehco1996

@Liuxiaozhen12 Liuxiaozhen12 removed the request for review from TomShawn July 19, 2021 03:44
@Liuxiaozhen12 Liuxiaozhen12 added type/enhancement This issue/PR improves documentation usability. and removed type/enhancement This issue/PR improves documentation usability. labels Jul 20, 2021
@glorv
Copy link

glorv commented Jul 21, 2021 •
edited
Loading

very sorry that developers have made typo 😂 but I think this typo should be fixed DM first. Considering the compatibility, we may choose not fix it

cc @glorv @GMHDBJD @lichunzhu @Ehco1996

So what are the affected versions? Shall we fix this in the next version(v2.0.5) and add a warn note for the misspelling keywords for affected versions in our document. 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM_dump/load/sync_process_exists_with_error 告警拼写错误
4 participants
@Liuxiaozhen12 @ti-chi-bot @lance6716 @glorv