-
Notifications
You must be signed in to change notification settings - Fork 188
Didn't fully support sync view while remove view from builtin skip DDLs #1300
Comments
in #1105 we allow syncing of CREATE VIEW, but didn't add an integration test (unit test didn't expose the problem, which maybe SplitDDL can't handle VIEW) |
since we didn't dump&load view, how about still filter out VIEW in sync 😂 |
or add support for dump&load view? |
OK, will learn from pingcap/tidb-lightning#417. I'm not sure this could be finished in coming release 😂 |
Just load views after all the tables have been loaded. Dumpling has already supported dumping views like mydumper pingcap/dumpling#158 |
A community user is questioning about dm supporting view yesterday. So this could be a customer issue in some cases. |
@lance6716 How is the progress of this issue? |
above this comment is a pull request that fixes this issue. if it gets reviewed quickly, this could be supported in nightly this week (but not well tested). |
block syncing of VIEW in #1331 and will support it later. changed to feature-request |
repalced by #1622 |
Bug Report
Please answer these questions before submitting your issue. Thanks!
create view in upstream
What did you expect to see?
What did you see instead?
error 11007 unknown type DDL
Versions of the cluster
DM version (run
dmctl -V
ordm-worker -V
ordm-master -V
):master
The text was updated successfully, but these errors were encountered: