-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission to bring changes upstream #97
Comments
Thank you for your excellent project. We use badger in an experimental project, not used in production yet. The license is still APACHE LICENSE 2.0. Of course, you can bring the optimizations back to the upstream, just reference our PR or commit link in the backport commit message would be enough. |
Thanks, we'll bring some of these optimizations back. If you can point us to the most important ones, that'd be very helpful. How is Badger's performance in your experiments? |
@manishrjain |
Nice. Pointers to some relevant commits? |
The initial fork picked this optimization dgraph-io#481 And then those are the related PRs, the earlier ones are more important. https://github.com/coocood/badger/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+optimize |
Hey guys,
You're doing some pretty interesting work on Badger. Kudos!
Curious: Are you guys using Badger at Pingcap?
Also, what license are your changes under? Can the Badger team bring back some of these optimizations that you have done, so we can improve Badger for all users?
Cheers,
Manish (Badger author)
The text was updated successfully, but these errors were encountered: