From d3daf2e5ca8fcb51128efab1b515c733fdfb214a Mon Sep 17 00:00:00 2001 From: Dave Rigby Date: Mon, 29 Apr 2024 15:03:32 +0100 Subject: [PATCH] Rename Pinecone-specific test scripts Qualify with Pinecone if they are not generic to other vector databases. --- .../action.yml | 8 ++++---- .../action.yml | 2 +- .github/workflows/python-package.yml | 14 +++++++------- .../{create_index.py => create_pinecone_index.py} | 0 .../{delete_index.py => delete_pinecone_index.py} | 0 5 files changed, 12 insertions(+), 12 deletions(-) rename .github/actions/{create-index => create-pinecone-index}/action.yml (85%) rename .github/actions/{delete-index => delete-pinecone-index}/action.yml (86%) rename tests/scripts/{create_index.py => create_pinecone_index.py} (100%) rename tests/scripts/{delete_index.py => delete_pinecone_index.py} (100%) diff --git a/.github/actions/create-index/action.yml b/.github/actions/create-pinecone-index/action.yml similarity index 85% rename from .github/actions/create-index/action.yml rename to .github/actions/create-pinecone-index/action.yml index 3b3390d..668e26d 100644 --- a/.github/actions/create-index/action.yml +++ b/.github/actions/create-pinecone-index/action.yml @@ -32,18 +32,18 @@ inputs: outputs: index_name: description: 'The name of the index, including randomized suffix' - value: ${{ steps.create-index.outputs.index_name }} + value: ${{ steps.create-pinecone-index.outputs.index_name }} index_host: description: 'The host of the index, including randomized suffix' - value: ${{ steps.create-index.outputs.index_host }} + value: ${{ steps.create-pinecone-index.outputs.index_host }} runs: using: 'composite' steps: - name: Create index - id: create-index + id: create-pinecone-index shell: bash - run: poetry run python3 tests/scripts/create_index.py + run: poetry run python3 tests/scripts/create_pinecone_index.py env: PINECONE_API_KEY: ${{ inputs.PINECONE_API_KEY }} NAME_PREFIX: ${{ inputs.name_prefix }} diff --git a/.github/actions/delete-index/action.yml b/.github/actions/delete-pinecone-index/action.yml similarity index 86% rename from .github/actions/delete-index/action.yml rename to .github/actions/delete-pinecone-index/action.yml index 5684785..a0f3c3a 100644 --- a/.github/actions/delete-index/action.yml +++ b/.github/actions/delete-pinecone-index/action.yml @@ -15,7 +15,7 @@ runs: steps: - name: Delete index shell: bash - run: poetry run python3 tests/scripts/delete_index.py + run: poetry run python3 tests/scripts/delete_pinecone_index.py env: PINECONE_API_KEY: ${{ inputs.PINECONE_API_KEY }} INDEX_NAME: ${{ inputs.index_name }} diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 88da763..5958b83 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -47,9 +47,9 @@ jobs: poetry run flake8 . --extend-exclude .venv --count --select=E9,F63,F7,F82 --show-source --statistics # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide poetry run flake8 . --extend-exclude .venv --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics - - name: Create test index - id: create-index - uses: ./.github/actions/create-index + - name: Create test Pinecone index + id: create-pinecone-index + uses: ./.github/actions/create-pinecone-index timeout-minutes: 2 with: environment: ${{ matrix.environment == 'pod' && 'us-east4-gcp' || '' }} @@ -60,12 +60,12 @@ jobs: poetry run pytest env: PINECONE_API_KEY: '${{ secrets.PINECONE_API_KEY }}' - INDEX_NAME: ${{ steps.create-index.outputs.index_name }} - - name: Delete test index + INDEX_NAME: ${{ steps.create-pinecone-index.outputs.index_name }} + - name: Delete test Pinecone index if: always() - uses: ./.github/actions/delete-index + uses: ./.github/actions/delete-pinecone-index timeout-minutes: 2 with: PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }} - index_name: ${{ steps.create-index.outputs.index_name }} + index_name: ${{ steps.create-pinecone-index.outputs.index_name }} diff --git a/tests/scripts/create_index.py b/tests/scripts/create_pinecone_index.py similarity index 100% rename from tests/scripts/create_index.py rename to tests/scripts/create_pinecone_index.py diff --git a/tests/scripts/delete_index.py b/tests/scripts/delete_pinecone_index.py similarity index 100% rename from tests/scripts/delete_index.py rename to tests/scripts/delete_pinecone_index.py