You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@yulka had originally sent me these notes per a change she made in her fork and wanted to share publicly so we could discuss in the open. Thanks, Yulka!
one reason I often end up overriding the base template is because it doesn’t support sticky footer. By adding block page and leaving block footer outside of it, we can add a couple of styles in css and have a have the footer stick
make markup more semantic: aside, section instead of div
make class names consistent, always use dashes: main-content, not main_content
use scss, not just css
create columns inside scss, keep them out of html (see changes to sidebar_base.html)
use sidebar_base.html instead of subnav_base.html, because there can be other content in the sidebar, not just navigation
give classes to the site header and footer since these html tags can be used in other places (header.header, footer.footer)
refactor account templates. markup there is very inconsistent and I always end up rewriting all those templates (e.g. always use h2 for page titles instead of a mix of h1, h2 and legend)
avoid tags like hr, borders can be added in css (see base.html, footer)
The text was updated successfully, but these errors were encountered:
One thing I'd like to see us do, is create a theme.less|scss file or set of files and package that along with the javascript that is in this theme so that pinax-theme-bootstrap doesn't have any static/ folder. We package up the statics in a complimentary npm package. Then we can potentially have any number of npm packages that work with these templates.
At this point, there wouldn't be anything particularly binding to the bootstrap framework and we could rename this project to just pinax-themes and the npm packages could use styles from bootstrap or other frameworks.
@yulka had originally sent me these notes per a change she made in her fork and wanted to share publicly so we could discuss in the open. Thanks, Yulka!
block page
and leavingblock footer
outside of it, we can add a couple of styles in css and have a have the footer stickaside
,section
instead ofdiv
main-content
, notmain_content
sidebar_base.html
instead ofsubnav_base.html
, because there can be other content in the sidebar, not just navigationheader
andfooter
since these html tags can be used in other places (header.header
,footer.footer
)h2
for page titles instead of a mix ofh1
,h2
andlegend
)hr
, borders can be added in css (see base.html, footer)The text was updated successfully, but these errors were encountered: