Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethink relationship between _account_bar in theme vs projects #106

Open
jtauber opened this issue Jan 30, 2016 · 2 comments
Open

rethink relationship between _account_bar in theme vs projects #106

jtauber opened this issue Jan 30, 2016 · 2 comments

Comments

@jtauber
Copy link
Member

jtauber commented Jan 30, 2016

At the moment, the theme contains an _account_bar appropriate to and assuming django-user-accounts is used. This is then zeroed out in starter projects that don't use django-user-accounts. The _account_bar seems to be then duplicated in the account project (we need to check if it's in fact exactly the same).

So Option 1 would be just make the _account_bar in PTB blank to remove the duplication.

Option 2 would be to rename the _account_bar in PTB to something else and a project that wants to use it includes that newly named template in their _account_bar

But then Patrick suggested Option 3 which I like more than Option 2: rather than have the extra level of indirection, just have the various starter projects either include PTB's _account_bar or not in their own site_base.html

@jtauber
Copy link
Member Author

jtauber commented Jan 30, 2016

As I think Option 3 is better than 2 but has roughly the same approach, I think it's down to 1 and 3 which really just come down to: should the actual account_bar live in the template or the base account starter project?

@jtauber
Copy link
Member Author

jtauber commented Jan 30, 2016

One thing to consider: some descendants of that account project may have richer _account_bars. How would they work?

@jtauber jtauber added this to the post-16.04 milestone Mar 18, 2016
@jtauber jtauber removed this from the post-16.07 milestone Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants