Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Update ADC() #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Examples: Update ADC() #966

wants to merge 1 commit into from

Conversation

helgibbons
Copy link
Contributor

Should help with #965

@helgibbons
Copy link
Contributor Author

I've not done anything with our Analog class in modules_py/pimoroni.py here, which might also need looking at?

@Gadgetoid
Copy link
Member

Thank you!

I guess in Analog it should be something like:

self.pin = ADC(pin) if isinstance(pin, Pin) else ADC(Pin(pin))

Looks like it's never actually called with a Pin instance, but it should probably handle that just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants