Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: quantityScale may be null in case of setting the price info quantity #172

Open
AlternateIf opened this issue Mar 14, 2024 · 1 comment

Comments

@AlternateIf
Copy link
Contributor

Expected behavior

Upon not passing a quantity scale it's default function value (null) should not cause an error

Actual behavior

quantity scale being null causes an error

Steps to reproduce

https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/PriceSystem/AbstractPriceSystem.php#L56 allows quantityScale to be null but https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/PriceSystem/AbstractPriceInfo.php#L44 expects it to be string or int. this causes an error (https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/PriceSystem/AbstractPriceSystem.php#L61)

Copy link

github-actions bot commented Apr 4, 2024

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant