Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong data type for classId in bundle_advancedobjectsearch_update_queue table #175

Open
AndrewKMoses opened this issue Oct 12, 2022 · 2 comments

Comments

@AndrewKMoses
Copy link

AndrewKMoses commented Oct 12, 2022

Expected behavior

Expected data type for column classId in table bundle_advancedobjectsearch_update_queue to be varchar as $classDefinition->getId() returns string.

Actual behavior

Data type is int.

Steps to reproduce

This is an issue when you use your own unique identifier on DataObject classes.

image

The issue can for example be seen below where $classDefinition->getId() is a string.

https://github.com/pimcore/advanced-object-search/blob/4.x/src/Service.php#L351

@AndrewKMoses
Copy link
Author

AndrewKMoses commented Oct 12, 2022

If I want to provide a PR for this, where do I put the migration?

There are migrations under src/Migrations and src/Migrations/PimcoreX but the migration under PimcoreX seems to not do anything?

@kingjia90
Copy link
Contributor

kingjia90 commented Oct 17, 2022

@AndrewKMoses i would say in both, that change was introduced in #71 for v.3.0.0 which was supporting pimcore <6.5, so by having it in both folder it should be fixing for every version and not specifically for X. Thank you in advance and looking forward for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants