Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing with MoarVM hash changes #13

Closed
samcv opened this issue Apr 30, 2018 · 2 comments
Closed

Tests failing with MoarVM hash changes #13

samcv opened this issue Apr 30, 2018 · 2 comments

Comments

@samcv
Copy link
Contributor

samcv commented Apr 30, 2018

With the recent MoarVM changes the hashes don't always return in a constant order (even without these changes it means that the tests probably wouldn't pass on perl6 running other VM backends).

Failures are in t/107-pack-hash.t, in which I get up to 2 failing tests (it can fail less if for that particular run of MoarVM it just so happens to return the previous order that the test expected).

@AlexDaniel
Copy link

@pierre-vigier
Copy link
Owner

Fixed now, thanks for the notice. Instead of checking the blob byte by byte, i pack, unpack and check the result against the original hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants