Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Typescript typings in v2.3.0 npm package #77

Open
psantos9 opened this issue Nov 4, 2024 · 4 comments
Open

No Typescript typings in v2.3.0 npm package #77

psantos9 opened this issue Nov 4, 2024 · 4 comments

Comments

@psantos9
Copy link

psantos9 commented Nov 4, 2024

Hi, first of all kudos for library!
I've installed v2.3.0 from npm and noticed that it doesn't have the TS typings included.
Can we expect a new release with those?

thank you
@FergusCoulter
Copy link

Second this!
Fantastic library but would be even better with some typings

@piercus
Copy link
Owner

piercus commented Nov 8, 2024

Hi @psantos9 @FergusCoulter,
Thanks for the feedback, need to check this

cc @UrielCh

@UrielCh
Copy link
Contributor

UrielCh commented Nov 8, 2024

I have so much change on my fork, an I do not remember what did I change within my side...

@UrielCh UrielCh mentioned this issue Nov 8, 2024
Merged
@UrielCh
Copy link
Contributor

UrielCh commented Nov 8, 2024

#78 should be enougth.

piercus added a commit that referenced this issue Nov 8, 2024
@piercus
Merge pull request #78 from UrielCh/addTypeDef
dd6ec76 
fix No Typescript typings in v2.3.0 npm package #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@piercus @psantos9 @UrielCh @FergusCoulter