Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensionless image not display properly on Safari & macOS <= 10.15 #110

Open
imcotton opened this issue Mar 24, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@imcotton
Copy link
Contributor

Screen shot taken from Safari (15.6) on macOS Catalina (10.15):

image missing

BTW, I reported this in issue #104 a couple of days back as follow up comment, seems been slipped due to ticket closed automatically, thus opening the new one instead.

@neurosnap
Copy link
Member

Thanks for the ping. How do you think we should handle this issue? We could sniff the User-Agent and fallback to default mime-type for the image. Thoughts?

@imcotton
Copy link
Contributor Author

I always handle images with extensions on the web. However, in rare cases like this, options in my mind:

  1. original mime type: mostly jpeg or png, obtained during the upload process

  2. do nothing, as for authors deliberately opt-in to the extensionless practice, and knowingly acknowledge the lack of support for users under Safari & macOS <= 10.15 (via statistics)

  3. sniffing, from the user-agent

I think option 1 is the safe move. For option 2 need some way to inform the authors beforehand. I don't have any experience with Option 3, but it seems to make things even more tricky.

@imcotton
Copy link
Contributor Author

I just noticed, as normal user, you can not upload files without extensions, so the impact / problem scope is limited to admins?

@neurosnap neurosnap added the bug Something isn't working label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants