manager.alter_column: changing on_delete doesn't seem to work

[Jacky56]

Assume you have the scenario of changing the existing on delete cascade behaviour:

class Post(Table):
    multimedia = ForeignKey(Multimedia, null=True, on_delete=OnDelete.set_null)

which then perform the auto migration to generates the code below:

async def forwards():
    manager = MigrationManager(
        migration_id=ID, app_name="post", description=DESCRIPTION
    )
    manager.alter_column(
        table_class_name="Post",
        tablename="post",
        column_name="multimedia",
        db_column_name="multimedia",
        params={"on_delete": OnDelete.set_null},
        old_params={"on_delete": OnDelete.cascade},
        column_class=ForeignKey,
        old_column_class=ForeignKey,
        schema=None,
    )
    return manager

The migration ran successfully but my FK cascade behaviour did not change

CockroachDB version: Basic, Google Cloud v24.3.4
Piccolo version: piccolo==1.21.0

[dantownsend]

Yes, you're right - I've noticed this too. The migrations don't detect this change at the moment, I need to fix it.