Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return type of save method is partially unknown #1154

Open
dantownsend opened this issue Feb 17, 2025 · 0 comments
Open

Return type of save method is partially unknown #1154

dantownsend opened this issue Feb 17, 2025 · 0 comments

Comments

@dantownsend
Copy link
Member

Every few months it seems like pyright gets stricter and detects more type errors.

This is partially ambiguous:

) -> t.Union[Insert, Update]:

Because Insert and Update use generics to specify which table it's being performed on. So instead of Insert, it should be Insert[TableInstance], or something like that.

We have ./scripts/pyright.sh for testing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant