Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use the treble clef in both staves #52

Open
glixx opened this issue Jun 4, 2019 · 6 comments
Open

Add option to use the treble clef in both staves #52

glixx opened this issue Jun 4, 2019 · 6 comments
Labels
enhancement New feature or request low priority TBD to be decided

Comments

@glixx
Copy link
Contributor

glixx commented Jun 4, 2019

Hi, pianobooster does not seem able to show scores with two treble clefs (also called dual-g clef, see http://www.theoreticallycorrect.com/MusicFiction/new-grand-staff/)

I was startin with Beyer Op. 101 (converting some exercises to midi and trying them in pianobooster), but they uses this dual-G clef notation.

As a begineer I would find it useful to have the score representetd like in the book (see the attachment). Can this be made configurable?

Thanks,
Antonio

Hi, I think I overlooked the article I was mentioning above about the "new grand staff".

That article was proposing a new notation to replace the Bass clef, and in fact on the bottom staff there was a "-2" to indicate that the staff was two octaves below, in order to cover the whole keyboard.

This is not what the Bayer notation implies, and not what I am proposing for pianobooster.
In the Bayer exercises the two staffs, which serve the purpose to communicate what each hand should play, have exactly the same Treble clef, in the sense that they refer to the same relative position on the keyboard.

I see it as a way to compare more intuitively what the two hands should do, relatively to a C note.

But regardless of why it is used, it is a notation which is used in the book, and I so tried to see what it would take to support it in pianobooster.

I am attaching a patch with a quick and dirty proof of concept.

And here is how PB looks with the patch applied, it matches the score from the book.

Hi Michael, my patch is just a rough expriment, it always forces the Treble clef, with no way of changing it back to the Bass cleff with the user interface.

To try it you'd need to recompile pianobooster from the source code. I am not on Windows so I won't be able to help there.

Beyer Op  101 - Exercise 003-1
Pianobooster-Beyer-003-two-treble-clefs
treble-cleff-on-both-staffs.txt

Original issue: https://sourceforge.net/p/pianobooster/bugs/10/

@ao2
Copy link

ao2 commented Jun 4, 2019

@glixx thanks for posting this here :)

@glixx
Copy link
Contributor Author

glixx commented Jun 4, 2019

@ao2 do you have better patch with adding this option? PR is always welcome.

@ao2
Copy link

ao2 commented Jun 4, 2019

@ao2 do you have better patch with adding this option? PR is always welcome.

Sorry, I don't, And I don't know when I'll be able to look at this again either.

@glixx glixx added enhancement New feature or request help wanted Extra attention is needed labels Jun 6, 2019
@pianobooster pianobooster added low priority and removed help wanted Extra attention is needed labels Apr 23, 2020
@pianobooster
Copy link
Owner

It could be useful . maybe PB could guess the clef symbol to use if both hands had lots of high notes.

@pianobooster pianobooster added the TBD to be decided label Apr 23, 2020
@ao2
Copy link

ao2 commented Apr 25, 2020

Hi, thanks for considering it.

I am available to test a better patch.

Ciao, Antonio

@gjdv gjdv mentioned this issue Feb 6, 2023
@gjdv
Copy link
Contributor

gjdv commented Feb 6, 2023

I implemented a more permanent solution in Pull Request #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority TBD to be decided
Projects
None yet
Development

No branches or pull requests

4 participants