Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6: after migration "Domains to be excluded from Top Domain Lists and Query Log" isn't excluded from "Top Domains" #2290

Open
thomasmerz opened this issue Feb 26, 2025 · 3 comments

Comments

@thomasmerz
Copy link

Versions

Core version is v6.0.4 (Latest: v6.0.4)
Web version is v6.0.1 (Latest: v6.0.1)
FTL version is v6.0.2 (Latest: v6.0.2)

Platform

  • OS and version: Docker
  • Platform: Docker

Expected behavior

After migration to V6 "Top Permitted Domains" and "Top Blocked Domains" does show "Domains to be excluded from Top Domain Lists and Query Log".

Actual behavior / bug

"Top Permitted Domains" and "Top Blocked Domains" should NOT show all "Domains to be excluded from Top Domain Lists and Query Log".

Steps to reproduce

See screenshots:

Screenshots

Image Image

After "fixing" ^*\.syncthing\.net$ to syncthing.net it doesn't show up anymore.

Is this an error while migration or with the regex?

@yubiuser yubiuser transferred this issue from pi-hole/pi-hole Feb 26, 2025
@DL6ER
Copy link
Member

DL6ER commented Mar 1, 2025

At first I was a bit confused but I think you just mixed the texts under "Expected behavior" and "Actual behavior / bug". All good.

After "fixing" ^*\.syncthing\.net$ to syncthing.net it doesn't show up anymore.

Is this an error while migration or with the regex?

The regex is wrong. ^* doesn't really mean anything, the ^* should probably not be there. I guess the string was *.syncthing.net before the migration?

@DL6ER
Copy link
Member

DL6ER commented Mar 1, 2025

Should be fixed by #2311

@thomasmerz
Copy link
Author

At first I was a bit confused but I think you just mixed the texts under "Expected behavior" and "Actual behavior / bug". All good.

The regex is wrong. ^* doesn't really mean anything, the ^* should probably not be there. I guess the string was *.syncthing.net before the migration?

Yes, I mixed the behaviours 😆 and yes, the "string was *.syncthing.net before the migration" 👍🏼 Thanks for fixing, waiting for release…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants