Skip to content

I2C pull up resistance variables - type, name, configuration #90

Open
@btsouts

Description

@btsouts

Describe the bug
Variables for I2C pull up resistance appear in various places with different type and semantics.

Variable menuI2cPullupValue in main functions is uint16_t and intended to be the I2C resistance value in Ohms.

Variable pullupValue in configureI2Cpins function is uint8_t and corresponds to the tap positions of the ISL23425 DCPs.

Required changes

  1. There are currently two ISL23425 DCPs which are configured with the same tap position value using configureI2Cpins function. We should modify the function to be able to take two values.
  2. A similar approach for menuI2cPullupValue, since there are two DCPs.
  3. We should add a function to map the menuI2cPullupValue Ohms value to ISL23425 DCP tap position.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions