Skip to content

Commit 15cda8f

Browse files
VincentLangletVincentLanglet
committed
More
1 parent 4574a21 commit 15cda8f

File tree

5 files changed

+66
-58
lines changed

5 files changed

+66
-58
lines changed

Diff for: ‎src/Reflection/RequireExtension/RequireExtendsPropertiesClassReflectionExtension.php

+8-16
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,8 @@ public function hasInstanceProperty(ClassReflection $classReflection, string $pr
4444
return $this->findProperty(
4545
$classReflection,
4646
$propertyName,
47-
// TODO: Use hasInstanceProperty
48-
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasProperty($propertyName),
49-
// TODO: Use getInstanceProperty
50-
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getProperty($propertyName, new OutOfClassScope())
47+
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasInstanceProperty($propertyName),
48+
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getInstanceProperty($propertyName, new OutOfClassScope())
5149
) !== null;
5250
}
5351

@@ -56,10 +54,8 @@ public function getInstanceProperty(ClassReflection $classReflection, string $pr
5654
$property = $this->findProperty(
5755
$classReflection,
5856
$propertyName,
59-
// TODO: Use hasInstanceProperty
60-
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasProperty($propertyName),
61-
// TODO: Use getInstanceProperty
62-
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getProperty($propertyName, new OutOfClassScope())
57+
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasInstanceProperty($propertyName),
58+
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getInstanceProperty($propertyName, new OutOfClassScope())
6359
);
6460
if ($property === null) {
6561
throw new ShouldNotHappenException();
@@ -73,10 +69,8 @@ public function hasStaticProperty(ClassReflection $classReflection, string $prop
7369
return $this->findProperty(
7470
$classReflection,
7571
$propertyName,
76-
// TODO: Use hasStaticProperty
77-
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasProperty($propertyName),
78-
// TODO: Use getStaticProperty
79-
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getProperty($propertyName, new OutOfClassScope())
72+
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasStaticProperty($propertyName),
73+
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getStaticProperty($propertyName, new OutOfClassScope())
8074
) !== null;
8175
}
8276

@@ -85,10 +79,8 @@ public function getStaticProperty(ClassReflection $classReflection, string $prop
8579
$property = $this->findProperty(
8680
$classReflection,
8781
$propertyName,
88-
// TODO: Use hasStaticProperty
89-
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasProperty($propertyName),
90-
// TODO: Use getStaticProperty
91-
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getProperty($propertyName, new OutOfClassScope())
82+
static fn (Type $type, string $propertyName): TrinaryLogic => $type->hasStaticProperty($propertyName),
83+
static fn (Type $type, string $propertyName): ExtendedPropertyReflection => $type->getStaticProperty($propertyName, new OutOfClassScope())
9284
);
9385
if ($property === null) {
9486
throw new ShouldNotHappenException();

Diff for: ‎src/Rules/Properties/AccessPropertiesCheck.php

+13-16
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
6767
$scope,
6868
NullsafeOperatorHelper::getNullsafeShortcircuitedExprRespectingScope($scope, $node->var),
6969
sprintf('Access to property $%s on an unknown class %%s.', SprintfHelper::escapeFormatString($name)),
70-
// TODO use hasInstanceProperty
71-
static fn (Type $type): bool => $type->canAccessProperties()->yes() && $type->hasProperty($name)->yes(),
70+
static fn (Type $type): bool => $type->canAccessProperties()->yes() && $type->hasInstanceProperty($name)->yes(),
7271
);
7372
$type = $typeResult->getType();
7473
if ($type instanceof ErrorType) {
@@ -94,8 +93,7 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
9493
];
9594
}
9695

97-
// TODO use hasInstanceProperty
98-
$has = $type->hasProperty($name);
96+
$has = $type->hasInstanceProperty($name);
9997
if (!$has->no() && $this->canAccessUndefinedProperties($scope, $node)) {
10098
return [];
10199
}
@@ -159,6 +157,16 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
159157
}
160158
}
161159

160+
if ($type->hasStaticProperty($name)->yes()) {
161+
return [
162+
RuleErrorBuilder::message(sprintf(
163+
'Non-static access to static property %s::$%s.',
164+
$type->getStaticProperty($name, $scope)->getDeclaringClass()->getDisplayName(),
165+
$name,
166+
))->identifier('staticProperty.nonStaticAccess')->build(),
167+
];
168+
}
169+
162170
$ruleErrorBuilder = RuleErrorBuilder::message(sprintf(
163171
'Access to an undefined property %s::$%s.',
164172
$typeForDescribe->describe(VerbosityLevel::typeOnly()),
@@ -175,18 +183,7 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
175183
];
176184
}
177185

178-
// TODO use getInstanceProperty
179-
$propertyReflection = $type->getProperty($name, $scope);
180-
if ($propertyReflection->isStatic()) {
181-
return [
182-
RuleErrorBuilder::message(sprintf(
183-
'Non-static access to static property %s::$%s.',
184-
$propertyReflection->getDeclaringClass()->getDisplayName(),
185-
$name,
186-
))->identifier('staticProperty.nonStaticAccess')->build(),
187-
];
188-
}
189-
186+
$propertyReflection = $type->getInstanceProperty($name, $scope);
190187
if ($write) {
191188
if ($scope->canWriteProperty($propertyReflection)) {
192189
return [];

Diff for: ‎src/Rules/Properties/AccessStaticPropertiesRule.php

+19-22
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,7 @@ private function processSingleProperty(Scope $scope, StaticPropertyFetch $node,
135135
$scope,
136136
NullsafeOperatorHelper::getNullsafeShortcircuitedExprRespectingScope($scope, $node->class),
137137
sprintf('Access to static property $%s on an unknown class %%s.', SprintfHelper::escapeFormatString($name)),
138-
// TODO Use hasStaticProperty
139-
static fn (Type $type): bool => $type->canAccessProperties()->yes() && $type->hasProperty($name)->yes(),
138+
static fn (Type $type): bool => $type->canAccessProperties()->yes() && $type->hasStaticProperty($name)->yes(),
140139
);
141140
$classType = $classTypeResult->getType();
142141
if ($classType instanceof ErrorType) {
@@ -168,8 +167,7 @@ private function processSingleProperty(Scope $scope, StaticPropertyFetch $node,
168167
]);
169168
}
170169

171-
// TODO Use hasStaticProperty
172-
$has = $classType->hasProperty($name);
170+
$has = $classType->hasStaticProperty($name);
173171
if (!$has->no() && $scope->isUndefinedExpressionAllowed($node)) {
174172
return [];
175173
}
@@ -202,6 +200,23 @@ private function processSingleProperty(Scope $scope, StaticPropertyFetch $node,
202200
}
203201
}
204202

203+
if ($classType->hasInstanceProperty($name)->yes()) {
204+
$hasPropertyTypes = TypeUtils::getHasPropertyTypes($classType);
205+
foreach ($hasPropertyTypes as $hasPropertyType) {
206+
if ($hasPropertyType->getPropertyName() === $name) {
207+
return [];
208+
}
209+
}
210+
211+
return array_merge($messages, [
212+
RuleErrorBuilder::message(sprintf(
213+
'Static access to instance property %s::$%s.',
214+
$classType->getInstanceProperty($name, $scope)->getDeclaringClass()->getDisplayName(),
215+
$name,
216+
))->identifier('property.staticAccess')->build(),
217+
]);
218+
}
219+
205220
return array_merge($messages, [
206221
RuleErrorBuilder::message(sprintf(
207222
'Access to an undefined static property %s::$%s.',
@@ -211,25 +226,7 @@ private function processSingleProperty(Scope $scope, StaticPropertyFetch $node,
211226
]);
212227
}
213228

214-
// TODO Use getStaticProperty and update the if
215229
$property = $classType->getProperty($name, $scope);
216-
if (!$property->isStatic()) {
217-
$hasPropertyTypes = TypeUtils::getHasPropertyTypes($classType);
218-
foreach ($hasPropertyTypes as $hasPropertyType) {
219-
if ($hasPropertyType->getPropertyName() === $name) {
220-
return [];
221-
}
222-
}
223-
224-
return array_merge($messages, [
225-
RuleErrorBuilder::message(sprintf(
226-
'Static access to instance property %s::$%s.',
227-
$property->getDeclaringClass()->getDisplayName(),
228-
$name,
229-
))->identifier('property.staticAccess')->build(),
230-
]);
231-
}
232-
233230
if (!$scope->canReadProperty($property)) {
234231
return array_merge($messages, [
235232
RuleErrorBuilder::message(sprintf(

Diff for: ‎src/Type/Accessory/HasPropertyType.php

+22
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult
7272

7373
public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
7474
{
75+
// TODO
7576
return new IsSuperTypeOfResult($type->hasProperty($this->propertyName), []);
7677
}
7778

@@ -87,6 +88,7 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
8788
$limit = IsSuperTypeOfResult::createMaybe();
8889
}
8990

91+
// TODO
9092
return $limit->and(new IsSuperTypeOfResult($otherType->hasProperty($this->propertyName), []));
9193
}
9294

@@ -120,6 +122,26 @@ public function hasProperty(string $propertyName): TrinaryLogic
120122
return TrinaryLogic::createMaybe();
121123
}
122124

125+
// TODO
126+
public function hasInstanceProperty(string $propertyName): TrinaryLogic
127+
{
128+
if ($this->propertyName === $propertyName) {
129+
return TrinaryLogic::createYes();
130+
}
131+
132+
return TrinaryLogic::createMaybe();
133+
}
134+
135+
// TODO
136+
public function hasStaticProperty(string $propertyName): TrinaryLogic
137+
{
138+
if ($this->propertyName === $propertyName) {
139+
return TrinaryLogic::createYes();
140+
}
141+
142+
return TrinaryLogic::createMaybe();
143+
}
144+
123145
public function getCallableParametersAcceptors(ClassMemberAccessAnswerer $scope): array
124146
{
125147
return [new TrivialParametersAcceptor()];

Diff for: ‎tests/PHPStan/Type/BenevolentUnionTypeTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function testCanAccessProperties(BenevolentUnionType $type, TrinaryLogic
4848
);
4949
}
5050

51-
public function dataHasProperty(): Iterator
51+
public function dataHasInstanceProperty(): Iterator
5252
{
5353
yield [
5454
new BenevolentUnionType([
@@ -75,10 +75,10 @@ public function dataHasProperty(): Iterator
7575
];
7676
}
7777

78-
/** @dataProvider dataHasProperty */
79-
public function testHasProperty(BenevolentUnionType $type, string $propertyName, TrinaryLogic $expectedResult): void
78+
/** @dataProvider dataHasInstanceProperty */
79+
public function testHasInstanceProperty(BenevolentUnionType $type, string $propertyName, TrinaryLogic $expectedResult): void
8080
{
81-
$actualResult = $type->hasProperty($propertyName);
81+
$actualResult = $type->hasInstanceProperty($propertyName);
8282
$this->assertSame(
8383
$expectedResult->describe(),
8484
$actualResult->describe(),

0 commit comments

Comments
 (0)