Skip to content

Commit f83d0de

Browse files
committed
tweak: do not double unserialize in getInstance
1 parent afd8f71 commit f83d0de

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/Cache.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ public function getArray(string $name, callable $callback, int $secondsValid = s
8080
* @return T
8181
*/
8282
public function getInstance(string $name, string $className, callable $callback, int $secondsValid = self::DEFAULT_SECONDS_VALID):object {
83-
$serialized = $this->get($name, $callback, $secondsValid);
84-
$value = unserialize($serialized);
83+
$value = $this->get($name, $callback, $secondsValid);
8584
if(get_class($value) !== $className) {
8685
throw new TypeError("Value is not of type $className");
8786
}

test/phpunit/CacheTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public function testGetInstance():void {
9191
$value->name = uniqid();
9292

9393
$sut = $this->getSut([
94-
"test" => serialize($value),
94+
"test" => $value,
9595
]);
9696
$class = $sut->getInstance("test", StdClass::class, fn() => false);
9797
self::assertSame($value->name, $class->name);

0 commit comments

Comments
 (0)