Allow "/" when editing code #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Regression report for commit 621bcce is at https://web-php-regression-report-pr-1177.preview.thephp.foundation |
|
🚀 Preview for commit 621bcce can be found at https://web-php-pr-1177.preview.thephp.foundation |
sy-records
reviewed
Dec 4, 2024
js/search.js
Outdated
Comment on lines
297
to
300
| if (event.target.contentEditable) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Changing it this way will make it impossible to use the / popup search input box
sy-records
requested changes
Dec 4, 2024
sy-records
approved these changes
Dec 4, 2024
|
Thanks @sy-records ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that you can't hit "/" when editing code, this fixes it. I was suprised that this part of the code doesn't use
mousetrapas injs/common.js.