Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor mistake in the PHP 8.4 example code for property hooks #1169

Closed
nitori opened this issue Nov 27, 2024 · 1 comment
Closed

Minor mistake in the PHP 8.4 example code for property hooks #1169

nitori opened this issue Nov 27, 2024 · 1 comment

Comments

@nitori
Copy link

nitori commented Nov 27, 2024

Hi,

I just noticed a very minor mistake in the example code at
https://www.php.net/releases/8.4/en.php

In the first example, the property hooks, on the right side it shows:

        get => \sprintf("%s_%s", $this->languageCode, $this->countryCode);
        set (string $value) {
            [$this->countryCode, $this->languageCode] = explode('_', $value, 2);
        }

The get assumes languageCode comes first, but the set expects countryCode as first item.

It should be the other way around for the setter, as the country code is at the end.

Greetings
Sani

@saundefined
Copy link
Member

@nitori thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants