Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identical examples are confusing #4336

Open
microshnik opened this issue Dec 21, 2024 · 0 comments
Open

identical examples are confusing #4336

microshnik opened this issue Dec 21, 2024 · 0 comments

Comments

@microshnik
Copy link

From manual page: https://php.net/language.oop5.property-hooks


The code examples for "Hook inheritance" (#9) and "Parent hook access (set)" (#10) are identical; it appears they were added this way in the initial commit. This is confusing, especially with the comment between them stating the former "could be rewritten more efficiently" as the latter, which is also present in the initial commit and not materially changed thereafter.

Please update either/both of these examples to show distinct approaches, or remove one of them along with the reference to rewriting. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants