Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLINFO_HEADER_OUT is "defined" twice in the manual #4085

Open
Girgias opened this issue Nov 17, 2024 · 2 comments
Open

CURLINFO_HEADER_OUT is "defined" twice in the manual #4085

Girgias opened this issue Nov 17, 2024 · 2 comments
Labels
QA Quality Assurance

Comments

@Girgias
Copy link
Member

Girgias commented Nov 17, 2024

This can give false positives about a constant having incorrect linking.

Not sure how to handle the markup that you created @Ayesh, do you have any ideas/opinions @haszi?

@Girgias Girgias added the QA Quality Assurance label Nov 17, 2024
@Ayesh
Copy link
Member

Ayesh commented Nov 17, 2024

CURLINFO_HEADER_OUT isn't a Curl option, but we were using it for ages now (with a custom debug handler to catch and store the output headers). All use cases for this constant in existing documents should be referring to the Curl option; not the new use case with the CURLOPT_DEBUGFUNCTION option.

I thought about this when working on #4069, because the context for CURLINFO_HEADER_OUT in the CURLOPT_DEBUGFUNCTION callback is different. So, all references to that constant syntax go like this:

<varlistentry xml:id="constant.curlinfo-header-out-debug">
          <term>
           <constant linkend="constant.curlinfo-header-out-debug">CURLINFO_HEADER_OUT</constant>

For curl_setopt($ch, CURLINFO_HEADER_OUT) use case, bare <constant>CURLINFO_HEADER_OUT</constant> should continue refer to the old use case. Any documents that want to link to the new CURLINFO_HEADER_OUT constant context can link to it as <constant linkend="constant.curlinfo-header-out-debug">CURLINFO_HEADER_OUT</constant>.

@haszi
Copy link
Contributor

haszi commented Nov 24, 2024

This is unfortunate but I think we can make the markup Ayesh is proposing work in PhD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

No branches or pull requests

3 participants