Added deprecation notice on TranslationLoader interface and some comments (#31)

* Added deprecation notice on TranslationLoader interface and some comments

* Use the interface as it was intended

* Added changelog

Author: Nyholm

Changelog.md

@@ -2,6 +2,16 @@
 
 The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release. 
 
+## 1.0.1
+
+### Fixed
+
+- The `LegacyTranslationReader` should also check for`Translation\SymfonyStorage\TranslationLoader`.
+
+### Changed
+
+- The `Translation\SymfonyStorage\TranslationLoader` was deprecated.
+
 ## 1.0.0
 
 ### Added

src/LegacyTranslationReader.php

@@ -12,7 +12,7 @@
 namespace Translation\SymfonyStorage;
 
 use Symfony\Component\Translation\MessageCatalogue;
-use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader;
+use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader as SymfonyTranslationLoader;
 
 /**
  * This loader is just a wrapper for Symfony TranslationLoader
@@ -29,7 +29,7 @@ final class LegacyTranslationReader // implements Symfony\Component\Translation\
 
     public function __construct($loader)
     {
-        if (!$loader instanceof TranslationLoader) {
+        if (!($loader instanceof TranslationLoader) && !($loader instanceof SymfonyTranslationLoader)) {
             throw new \LogicException(sprintf('PHP-Translation/SymfonyStorage does not support a TranslationReader of type "%s".', get_class($loader)));
         }
         $this->loader = $loader;

src/LegacyTranslationWriter.php

@@ -22,6 +22,9 @@
  */
 final class LegacyTranslationWriter // implements Symfony\Component\Translation\Writer\TranslationWriterInterface
 {
+    /**
+     * @var TranslationWriter (This is a concrete class, the interface did not exist until sf 3.4)
+     */
     private $writer;
 
     public function __construct($writer)

src/TranslationLoader.php

@@ -14,6 +14,8 @@
 use Symfony\Component\Translation\MessageCatalogue;
 
 /**
+ * @deprecated Will be removed in 2.0. Please use Symfony\Component\Translation\Reader\TranslationReaderInterface.
+ *
  * @author Tobias Nyholm <[email protected]>
  */
 interface TranslationLoader