refactor: tool var names and exceptions (#20)

* refactor: tool var names and exceptions

* fix: phpstan and psr/cache dependency

Author: chr-hertel

composer.json

@@ -19,10 +19,12 @@
         "phpstan/phpstan": "^2.1",
         "phpunit/phpunit": "^11.5",
         "symfony/console": "^6.4 || ^7.0",
-        "rector/rector": "^2.0"
+        "rector/rector": "^2.0",
+        "psr/cache": "^3.0"
     },
     "suggest": {
-        "symfony/console": "To use SymfonyConsoleTransport for STDIO"
+        "symfony/console": "To use SymfonyConsoleTransport for STDIO",
+        "psr/cache": "To use CachePoolStore with SSE Transport"
     },
     "autoload": {
         "psr-4": {

src/Capability/Tool/MetadataInterface.php

@@ -10,5 +10,8 @@ public function getName(): string;
 
     public function getDescription(): string;
 
+    /**
+     * @return array<string, mixed>
+     */
     public function getInputSchema(): array;
 }

src/Exception/ExceptionInterface.php

@@ -4,8 +4,6 @@
 
 namespace PhpLlm\McpSdk\Exception;
 
-use PhpLlm\LlmChain\Exception\ExceptionInterface as BaseExceptionInterface;
-
-interface ExceptionInterface extends BaseExceptionInterface
+interface ExceptionInterface
 {
 }

src/Exception/ToolExecutionException.php

@@ -4,17 +4,14 @@
 
 namespace PhpLlm\McpSdk\Exception;
 
-use PhpLlm\LlmChain\Model\Response\ToolCall;
+use PhpLlm\McpSdk\Capability\Tool\ToolCall;
 
 final class ToolExecutionException extends \RuntimeException implements ExceptionInterface
 {
-    public ?ToolCall $toolCall = null;
-
-    public static function executionFailed(ToolCall $toolCall, \Throwable $previous): self
-    {
-        $exception = new self(sprintf('Execution of tool "%s" failed with error: %s', $toolCall->name, $previous->getMessage()), previous: $previous);
-        $exception->toolCall = $toolCall;
-
-        return $exception;
+    public function __construct(
+        public readonly ToolCall $toolCall,
+        ?\Throwable $previous = null,
+    ) {
+        parent::__construct(sprintf('Execution of tool "%s" failed with error: %s', $toolCall->name, $previous->getMessage()), previous: $previous);
     }
 }

src/Exception/ToolNotFoundException.php

@@ -4,23 +4,13 @@
 
 namespace PhpLlm\McpSdk\Exception;
 
-use PhpLlm\LlmChain\Chain\Toolbox\ExecutionReference;
-use PhpLlm\LlmChain\Model\Response\ToolCall;
+use PhpLlm\McpSdk\Capability\Tool\ToolCall;
 
 final class ToolNotFoundException extends \RuntimeException implements ExceptionInterface
 {
-    public ?ToolCall $toolCall = null;
-
-    public static function notFoundForToolCall(ToolCall $toolCall): self
-    {
-        $exception = new self(sprintf('Tool not found for call: %s.', $toolCall->name));
-        $exception->toolCall = $toolCall;
-
-        return $exception;
-    }
-
-    public static function notFoundForReference(ExecutionReference $reference): self
-    {
-        return new self(sprintf('Tool not found for reference: %s::%s.', $reference->class, $reference->method));
+    public function __construct(
+        public readonly ToolCall $toolCall,
+    ) {
+        parent::__construct(sprintf('Tool not found for call: %s.', $toolCall->name));
     }
 }

src/Server/RequestHandler/ToolCallHandler.php

@@ -14,7 +14,7 @@
 final class ToolCallHandler extends BaseRequestHandler
 {
     public function __construct(
-        private readonly ToolExecutorInterface $toolbox,
+        private readonly ToolExecutorInterface $toolExecutor,
     ) {
     }
 
@@ -24,7 +24,7 @@ public function createResponse(Request $message): Response|Error
         $arguments = $message->params['arguments'] ?? [];
 
         try {
-            $result = $this->toolbox->execute(new ToolCall(uniqid('', true), $name, $arguments));
+            $result = $this->toolExecutor->execute(new ToolCall(uniqid('', true), $name, $arguments));
         } catch (ExceptionInterface) {
             return Error::internalError($message->id, 'Error while executing tool');
         }

src/Server/RequestHandler/ToolListHandler.php

@@ -12,7 +12,7 @@
 final class ToolListHandler extends BaseRequestHandler
 {
     public function __construct(
-        private readonly ToolCollectionInterface $toolbox,
+        private readonly ToolCollectionInterface $toolCollection,
     ) {
     }
 
@@ -30,7 +30,7 @@ public function createResponse(Request $message): Response
                         '$schema' => 'http://json-schema.org/draft-07/schema#',
                     ] : $inputSchema,
                 ];
-            }, $this->toolbox->getMetadata()),
+            }, $this->toolCollection->getMetadata()),
         ]);
     }