Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tags from navigation #461

Open
patricksan opened this issue Oct 2, 2013 · 0 comments
Open

Remove tags from navigation #461

patricksan opened this issue Oct 2, 2013 · 0 comments
Assignees
@httpdispatch
Labels
To be tested ★★★

Comments

@patricksan
Copy link
Member

When the user is a collaborator we need to remove TAGS from the navigation
@ghost ghost assigned httpdispatch Oct 2, 2013
httpdispatch added a commit to httpdispatch/mobile-android that referenced this issue Oct 10, 2013
@httpdispatch
Issue photo#461 (Card 9) (Remove tags from navigation for collaborators)
2f9e84d 
app:
- MainActivity: replaced NavigationFragment index constant acccess with
the proper get methods from nafigationFragment field everywhere
- NavigationHandlerFragment: removed index constants such as they are
not constants anymore
- NiavigationHandlerFragment: added new methods getGalleryIndex,
getAlbumsIndex, getTagsIndex, getSyncIndex, getAccountIndex, hasTags
- NavigationHandlerFragment: replaced index constant access with
corresponding methods everywhere
- NavigationHandlerFragment: added hasTags check to the initPager method
before adding tags to the navigation
- Preferences added new methods setAccountAccessType,
getAccountAccessType, isLimitedAccountAccessType
- Credentials: added new access type constants
- Credentials: added mType field and it support to Parcelable
implementation and constructor
- Credentials: added getType getter
- Credentials: added static method saveCredentials and saving of account
access type to preferences cache there
- res/values/settings.xml: added setting_account_access_type constant
test:
- GalleryActivityTest, MainActivityTest: fixed compilation issues caused
by NavigationHandlerFragment updates
- CredentialsTest: added new test case testCredentialsParcelableV2
- CredentialsTest: updated checkCredentialsV2 signature (added type
support)
- AccountTroveboxResponseTest: updated calls of
CredentialsTest.checkCredentialsV2 with proper types in the
testMultiResponseV2 method
- res/raw/json_credentials_v2.txt: added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@httpdispatch httpdispatch

Labels
To be tested ★★★
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patricksan @httpdispatch