Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing photos from mobile - shows all picture - even device pictures #448

Open
CDEEEE opened this issue Jun 3, 2013 · 9 comments
Open

Comments

@CDEEEE
Copy link

CDEEEE commented Jun 3, 2013

When I choose sync photos from my mobile, it chooses every directory on my phone so I need to swipe about 15 times before I get to the right pictures. Can this be fixed so it either choose the same photo albums shown in the standard gallery included in Android or allow you to select which folders to choose from. Any kind of filter should help. Thanks

@httpdispatch
Copy link
Contributor

If i understand you right and you want to upload single photo with standard gallery navigation you can click on camera icon and choose option 'Gallery'. Is that it?

@CDEEEE
Copy link
Author

CDEEEE commented Jun 4, 2013

I hit the upload limit in the free service so it would let me hit the camera to test this out. I am not sure why anyone would want to sync icons, etc.

@httpdispatch
Copy link
Contributor

@CDEEEE you can remove few photos from trovebox. This will decrease upload counter so you will be able to upload again.

@CDEEEE
Copy link
Author

CDEEEE commented Jun 5, 2013

Hitting photo icon allows the upload of only one picture at a time which is not too friendly. Still not sure why sync shows thousands of system icon and others. I can't even tell where they are being pulled from. If I can find the source folders I may be able to fix.

@httpdispatch
Copy link
Contributor

Sync tab shows all photos which are present in mediastore. Same photos you can see in gallery but there they are grouped by folders

@httpdispatch
Copy link
Contributor

We can try to use StrickyGridHeader to separate images in the sync tab by folders. It will look like this:

image
image
image
image

@CDEEEE @patricksan @jmathai what do you think?

@patricksan
Copy link
Member

@httpdispatch I will discuss with @jmathai. For now, not priority unfortunately.

@CDEEEE
Copy link
Author

CDEEEE commented Jun 9, 2013

@httpdispatch What do you mean by the mediastore? Is that a folder on my device or on the cloud? I am talking about the folders from my device. Maybe I am misunderstanding the point of the sync. Thanks

@httpdispatch
Copy link
Contributor

@CDEEEE mediastore is the database which contains information about media present on the device link. Sync tab shows images present in that database. Same you can see in native gallery application but grouped by album/date or other parameters.

httpdispatch added a commit to httpdispatch/mobile-android that referenced this issue Oct 2, 2013
- SyncImageSelectionFragment: changed type of photosGrid to
StickyGridHeadersGridView
- SyncImageSelectionFragment: replaced setNumbColumn with reseting of
item height of adapter in the onDetach method
- SyncImageSelectionFragment: added dummy adapter for photos grid to the
on init method to avoid errors of StickyGridHeaders
- SyncImageSelectionFragment: replaced initiated check in the view tree
observer in the init method with the item height check. Removed
setNumbColumns call
- SyncImageSelectionFragment: changed condition for the refresh call in
the init method (grid adapter is not null anymore, it is either set or
is dummy)
- SyncImageSelectionFragment.ImageData: added additional field folder
and its handling to the constructor and parcelable implementation
- SyncImageSelectionFragment.ImageData: added new method
getFolderFromPath
- SyncImageSelectionFragment.InitTask: replaced setAdapter(null) with
setting of dummy adapter to photosGrid such as StickyGridHeaders doesn't
support null adapter on the onPreExecute method
- SyncImageSelectionFragment.DummyImageAdapter: added
- SyncImageSelectionFragment.CustomImageAdapter: now it implements
StickyGridHeadersSimpleAdapter
- SyncImageSelectionFragment.CustomImageAdapter: added viewholder
optimization to the getViewAdditional method
- SyncImageSelectionFragment.CustomImageAdapter: added new methods
implementation: getHeaderId, getHeaderView
- SyncImageSelectionFragment.CustomImageAdapter.ViewHolder: added
- SyncImageSelectionFragment.CustomImageAdapter.HeaderViewHolder: added
- SyncImageSelectionFragment.ImageAdapter: removed fields mNumColumns,
mActionBarHeight. Added inflater field. Removed setNumbColumns and
getNumColumns methods
- SyncImageSelectionFragment.ImageAdapter: removed top row handling from
the getView method
- SyncImageSelectionFragment.CustomImageWorkerAdapter: updated sorting
in the sort method to be by folder first and then by processed/not
processed
- /res/layout/fragment_sync_select_photos.xml: replaced GridView with
StickyGridHeadersGridView
- /res/layout/sync_category_separator.xml: added
- /project.properties: removed PhotoView library (now it is included as
source folder) and added StickyGridHeaders library
- /submodules/StickyGridHeaders: added
- /.classpath: added photoview src folder and adt 22 library export
record
- /.project: added new linked resource and variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants