Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pts/fio-2.1.0 missing parameter #58

Open
jojolope opened this issue Sep 10, 2024 · 0 comments
Open

pts/fio-2.1.0 missing parameter #58

jojolope opened this issue Sep 10, 2024 · 0 comments

Comments

@jojolope
Copy link

I noticed that the buffered option is gone in the last version:
When I add the following options:

export PRESET_OPTIONS="pts/fio.type=4;pts/fio.engine=0;pts/fio.cpu-threads=0;pts/fio.direct=1;pts/fio.size=0;pts/fio.auto-disk-mount-points=/data"

the test fails:


========================================================================================================
Flexible IO Tester (Run 1 of 1)
Type: Random Read - Engine: IO_uring - Direct: Yes - Block Size: 4KB - Job Count: 1 - Disk Target: /data
========================================================================================================

Test Run Directory: /data/pts/fio-2.1.0/

Test Run Command: ./fio-run randread io_uring 1 4k 1 /data

fio: failed parsing numjobs=/data
fio: job global dropped

The test quit with a non-zero exit status.

Looking at the script, the parameter $5 is missing.
Am I missing something or should that be changed like the following?:

--- fio-run.orig        2024-09-10 14:11:07.975474262 +0000
+++ fio-run     2024-09-10 14:13:46.392203596 +0000
@@ -1,16 +1,16 @@
 #!/bin/sh
 cd fio-3.36
-if [ "X$7" = "X" ]
+if [ "X$6" = "X" ]
 then
        DIRECTORY_TO_TEST="fiofile"
 else
-       DIRECTORY_TO_TEST="$7/fiofile"
+       DIRECTORY_TO_TEST="$6/fiofile"
 fi
-if [ "X$6" = "X" ]
+if [ "X$5" = "X" ]
 then
        NUM_JOBS=1
 else
-       NUM_JOBS="$6"
+       NUM_JOBS="$5"
 fi
 if [ "$2" = "io_uring" ]
 then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant