Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injected scripts should listen to DOM load #120

Closed
mwbrooks opened this issue Jun 10, 2015 · 2 comments
Closed

Injected scripts should listen to DOM load #120

mwbrooks opened this issue Jun 10, 2015 · 2 comments
Labels
enhancement
Milestone
Issues & Improvem...

Comments

@mwbrooks
Copy link
Collaborator

As pointed out by #119, we currently listen for deviceready. This has the downside of not initializing when the developer does not include cordova.js.
@timkim timkim mentioned this issue Jul 6, 2015
Open
@mwbrooks mwbrooks added this to the Maintenance 2015 milestone Sep 16, 2015
@surajpindoria
Copy link
Collaborator

This issue is related to #161.

@surajpindoria
Copy link
Collaborator

After investigating this it looks like there is no way around using deviceready in the injected scripts. Changing the event works fine if cordova.js is included, but there are issues if we have problems loading it. During the update process on the device we make calls to cordova plugins, no cordova.js means no access to plugins, therefore we cannot update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
Issues & Improvements
Development

No branches or pull requests
2 participants
@mwbrooks @surajpindoria