Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite generated code - wrong wording? #5945

Open
Hermanverschooten opened this issue Oct 5, 2024 · 0 comments
Open

sqlite generated code - wrong wording? #5945

Hermanverschooten opened this issue Oct 5, 2024 · 0 comments

Comments

@Hermanverschooten
Copy link
Contributor

Environment

  • Elixir version (elixir -v): 1.17.3
  • Phoenix version (mix deps): 1.7.14
  • Operating system: MacOS 15.0

Actual behavior

When generating a new Phoenix app with --database sqlite3, a call to Ecto.Migrator is added to the list of children.
This has a :skip? option that uses this generated function:

  defp skip_migrations?() do
    # By default, sqlite migrations are run when using a release
    System.get_env("RELEASE_NAME") != nil
  end

The comment and the result are different, by default this returns true in a release, which causes the migrations to be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant