Assertion running fuzzel

[mattlacey]

Off to a great start with this! Will grab the source sometime and have a play at building and tinkering.

Anyway, installed fuzzel, and running it triggers an assertion, something to do with layout at a guess:

2025-01-12 10:57:04.687 (FATAL) usr/src/debug/wlmaker/wlmaker-0.4.1/src/toolkit/panel.c:168 ASSERT failed: anchor & WLR_EDGE_LEFT && anchor & WLR_EDGE_RIGHT

[phkaeser]

Hej Matt! Thank you for reporting the issue.
I know I had set the assertions based on how I had been reading the "layer" extension specification; but there's good room for (1) me getting it wrong, or (2) fuzzel being slightly off the written spec.

Could you document what version of fuzzel you had been using, and what commandline you used?
(and, you used wlmaker 0.4.1 source package or a distro build?)

[mattlacey]

I'll grab the version tonight if I can - I used a package for Arch (pretty sure it's a first party one, likely just installed with pacman -S fuzzel) just ran it with fuzzel from a terminal.

I'm running the 0.4.1 AUR for wlmaker at the moment

[phkaeser]

A quick test on the developer laptop I had at hand:

fuzzel version: 1.9.2 +cairo +png +svg(nanosvg) -assertions

Gave me a Unsupported setting for keyboard interactivity: 1 protocol warning, from https://github.com/phkaeser/wlmaker/blob/main/src/layer_panel.c#L278.

Concluding:

• Some version of fuzzel may have an improper use of layout setup. Not in 1.9.2, though.
• wlmaker should not crash on such a situation, but should repond with a IMPLEMENTATION error.
• fuzzel requires keyboard interactivity. That is (so far) missing on wlmaker.

=> A different version may have it not crash, but keyboard interactivity will be missing.

@mattlacey -> highly interested in knowing your fuzzel version, since I'm curious whether that layout setup is in an earlier version of what I tested with.

What to do:

• fix wlmaker to not crash (that should be simple. Ideally add a method to verify & enforce validity of the wlmtk_panel_positioning_t arg in toolkit/panel.c; and call that from layer_panel.c);
• add support for keyboard interactivity in layer_panel.c (that may be harder to do).

[mattlacey]

I bet you feel like your todo list is growing rather fast right now!

fuzzel --version gives me: fuzzel version: 1.11.1 +cairo +png +svg(librsvg) -assertions

[phkaeser]

😅 -- there's always more TODO than available time...

Thanks for reporting the version! Curious that the more recent version has that behaviour. So we do have a disgreement between wlmaker and fuzzel on the layouting specifics. Will look into that and also compare with other wlroots-based compositors.

[mattlacey]

Yeah I know that feeling, never have enough time for all my side projects. I'll grab the source soon though and attempt to build from that, very keen to see this do well because I loved running WindowMaker back in the day and even though it's had some love recently (ish) I like the idea of going all-new as well with the switch to Wayland.