update firecrawl toolkit with map, crawl status check, async crawl methods #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi/tools/firecrawl.py
Outdated
Comment on lines
30
to
31
| self.api_key: Optional[str] = api_key or os.getenv("FIRECRAWL_API_KEY") | ||
| self.api_url: Optional[str] = api_url or os.getenv("FIRECRAWL_API_URL", "https://api.firecrawl.dev") |
There was a problem hiding this comment.
Add an if condition to check if API key is available. If not then raise an error
There was a problem hiding this comment.
I noticed in other tools implementation, rather than raise, logger.error was used and within the methods of the ToolKit also I noticed return rather than raise if api_key is not available. this makes me believe the parent components using tools like Assistant class does not handle exception classes ?
If this is the case, I will make some minor changes at my end in the script as well.
Pls correct me if I am wrong or if I am missing here something. @manthanguptaa
sharing the results screenshot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes implemented:
map_websitefor mapping functionality via firecrawl python sdkapi_urlin theToolkitsub-class initialization attributes, since firecrawl allows self-hosting service.formatsattributes incrawl_website,scrape_website, andasync_crawl_websitemethod - ( avoid making an additional request to firecrawl if invalid output format )limitparam intocrawl_limit&map_limitto avoid incosistency in response fetching since both the params serve different purpose.crawl_limit- maximum number of webpages to include in crawlingmap_limit- maximum number of web URLs to return.This PR aims to close #1349