-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving amplitude to 0 repeatedly results in waves being deleted, buggy-looking waves #333
Comments
Setting the wave amplitude to zero has the same effect on the temporal mask as turning off the wave generator. Hence it suffers from the same buggy behavior as described in #319 (comment). I'm not sure how this could be addressed, leaving assigned to @arouinfar and @ariel-phet to discuss and prioritize. |
Deferring for now, we will reevaluate after 1.0. However, it seems like the action required to cause this bugginess is not pedagogically productive anyhow, so we might just leave as is. |
Something I noticed in phetsims/qa#424. When you let the wave go normally after this, it continues to look pixelated. |
Without moving to a fully analytic model, I'm not sure how I would address the above problem. @arouinfar or @ariel-phet do you want any investigation on this before publication? @KatieWoe how long does the pixellation last before it dissipates? |
It really only stops when you change the wave, such as the frequency. It might dissipate eventually, but it didn't seem to while I watched. |
@samreid @ariel-phet the pixelation only seems to occur after pretty harshly scrubbing the amplitude slider. Gradual/less frequent changes in amplitude don't lead to noticeable noise/pixellation in the lattice. Given @samreid's assessment in #333 (comment) and the fact that the initiating behavior is more of an edge case (and not pedagogically useful), I'm fine with continuing to defer this issue. I'd also be fine with closing this as |
I hadn't previously been involved with this issue (that I can recall), so I'm unsubscribing. Let me know if you need feedback from me. |
Sorry, Chris! I tagged the wrong dev. 🙈 |
@arouinfar @samreid I think I am going to go with |
For phetsims/qa#274. Seen on multiple devices. Propagating waves can be "deleted" by moving amplitude to 0 repeatedly.
The text was updated successfully, but these errors were encountered: