Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply temporal masking only in views so it doesn't disrupt the propagation #306

Closed
samreid opened this issue Jan 10, 2019 · 4 comments
Closed
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jan 10, 2019

Perhaps if we apply the temporal masking in the downstream views only, it will not perturb the wave physics. We would need to apply it in all downstream views, including (but perhaps not limited to) the wave area display, the chart display, the intensity screen, etc.

@arouinfar do you think that's worth investigation? It may be one way to address #304

@samreid
Copy link
Member Author

samreid commented Jan 10, 2019

@arouinfar and I discussed this and agreed it sounds like it is worth investigation.

@samreid
Copy link
Member Author

samreid commented Jan 10, 2019

This will also allow us to use a very narrow band (no tolerance) without disrupting the integration.

@arouinfar arouinfar removed their assignment Jan 10, 2019
samreid added a commit that referenced this issue Jan 10, 2019
@samreid
Copy link
Member Author

samreid commented Jan 10, 2019

Proposed fix is here and working great in initial testing. Here's a dev version with this fix: https://phet-dev.colorado.edu/html/wave-interference/1.0.0-dev.59/phet/wave-interference_en_phet.html

@samreid
Copy link
Member Author

samreid commented Jan 10, 2019

We agreed this is looking good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants