Enum improvements

[samreid]

Let's follow the proposal in phetsims/phet-core#53 and reassign to @pixelzoom when ready.

[samreid]

I moved to this pattern for DisturbanceType in this commit d538c9d, @pixelzoom would you mind doing a micro-review before I continue?

Also, I noted that unfortunately WebStorm doesn't know how to highlight this too well and is showing a lot of gray underlines:

[pixelzoom]

Looks good to me.

[samreid]

I fixed up the other enums, @pixelzoom can you please review? Close if all is well.

[pixelzoom]

Enumerations look great. Questions about a few related fields:

(1) Should this field in Scene be documented as "read-only"?

// @public {WaveSpatialType}
this.waveSpatialType = ...

(2) I wonder if this Property in SoundScene might be better named soundViewTypeProperty, since it's value is of type SoundViewType.

      // @public - indicates the selected view for sound
      this.viewSelectionProperty = new Property( SoundScene.SoundViewType.WAVES, {
        validValues: SoundScene.SoundViewType.VALUES
      } );

(3) Similarly in DiffractionModel, I wonder if this Property might be better named apertureTypeProperty:

      // @public - selected scene
      this.sceneProperty = new Property( DiffractionModel.ApertureType.CIRCLE, {
        validValues: DiffractionModel.ApertureType.VALUES
      } );

[samreid]

Thanks, I followed your recommendations, ready for review.

[pixelzoom]

👍 Closing.