Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilate Pointer Areas Around Wave button? #252

Closed
KatieWoe opened this issue Dec 14, 2018 · 8 comments
Closed

Dilate Pointer Areas Around Wave button? #252

KatieWoe opened this issue Dec 14, 2018 · 8 comments

Comments

@KatieWoe
Copy link
Contributor

I noticed that, when using an iPad, it seemed like pushing the button to start the wave didn't always work. I looked at the touch pointer areas from those button and they look pretty small. I think it might be useful if they are a bit bigger. We'd have to be careful that they don't overlap when separation between two sources is as small as possible, but even a slightly larger target might be useful.
For phetsims/qa#238

@arouinfar
Copy link
Contributor

Great suggestion @KatieWoe! This is the worst case scenario for the Interference screen, which should still leave ample room for dilation of the touch area around the on/off button.
image

@samreid seems like we could make the touch areas pretty generous here. Let's try something like this:

This touch area would apply to the source on/off button for all scenes/screens.

@arouinfar arouinfar removed their assignment Dec 15, 2018
@samreid
Copy link
Member

samreid commented Dec 15, 2018

Here's a dilation of 8 view coordinates:

image

Pushed and ready for review, @arouinfar can you please take a look?

@arouinfar
Copy link
Contributor

Looks good to me @samreid! @KatieWoe can you try this out on an iPad?

@arouinfar arouinfar assigned KatieWoe and unassigned arouinfar Dec 15, 2018
@KatieWoe KatieWoe assigned arouinfar and unassigned KatieWoe Dec 17, 2018
@KatieWoe
Copy link
Contributor Author

Looks good on the Waves and Interference screen. Not implemented on the Slits screen. Do we want it to be @arouinfar?

@samreid
Copy link
Member

samreid commented Dec 17, 2018

That was not intentional, self-assigning to fix that up.

@samreid
Copy link
Member

samreid commented Dec 17, 2018

Proposed fix pushed, @KatieWoe can you please double check and close if all is well?

@samreid samreid assigned KatieWoe and unassigned samreid Dec 17, 2018
@KatieWoe
Copy link
Contributor Author

Looks good in master.

@arouinfar
Copy link
Contributor

Not implemented on the Slits screen. Do we want it to be @arouinfar?

Good catch @KatieWoe! Thanks for taking care of it @samreid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants