-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dilate Pointer Areas Around Wave button? #252
Comments
Great suggestion @KatieWoe! This is the worst case scenario for the Interference screen, which should still leave ample room for dilation of the touch area around the on/off button. @samreid seems like we could make the touch areas pretty generous here. Let's try something like this: This touch area would apply to the source on/off button for all scenes/screens. |
Here's a dilation of 8 view coordinates: Pushed and ready for review, @arouinfar can you please take a look? |
Looks good on the Waves and Interference screen. Not implemented on the Slits screen. Do we want it to be @arouinfar? |
That was not intentional, self-assigning to fix that up. |
Proposed fix pushed, @KatieWoe can you please double check and close if all is well? |
Looks good in master. |
Good catch @KatieWoe! Thanks for taking care of it @samreid. |
I noticed that, when using an iPad, it seemed like pushing the button to start the wave didn't always work. I looked at the touch pointer areas from those button and they look pretty small. I think it might be useful if they are a bit bigger. We'd have to be careful that they don't overlap when separation between two sources is as small as possible, but even a slightly larger target might be useful.
For phetsims/qa#238
The text was updated successfully, but these errors were encountered: