Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag measure tape and barrier with same touch input #243

Closed
KatieWoe opened this issue Dec 13, 2018 · 9 comments
Closed

Drag measure tape and barrier with same touch input #243

KatieWoe opened this issue Dec 13, 2018 · 9 comments

Comments

@KatieWoe
Copy link
Contributor

Device
iPad (2018)
OS
iOS 12
Browser
Safari
Problem Description
For phetsims/qa#238
It is possible to accidentally "pick up" the barrier while dragging the measuring tape across. This can be replicated with the touch screen on Win 10, but much less reliably. It does not occur every time.
Steps to Reproduce

  1. Go to the sim on an iPad
  2. Go to the slits screen
  3. Pick up the measure tape and drag it back and forth over the divider without picking up your finger

Screenshot
https://drive.google.com/file/d/1p4pRxbdvg2cSjI97412BbreWKvcinM9W/view?usp=sharing

@samreid
Copy link
Member

samreid commented Dec 13, 2018

We should endeavor to solve this, though it would not block publication.

@KatieWoe
Copy link
Contributor Author

Note for @ariel-phet. Letting go drops both objects

@samreid
Copy link
Member

samreid commented Dec 14, 2018

I can also use the measuring tape to pick up the timer.

@samreid
Copy link
Member

samreid commented Dec 14, 2018

I've proposed a fix in phetsims/scenery#910 but it would be best for @jonathanolson to take a look before we proceed. On hold until then.

@samreid
Copy link
Member

samreid commented Dec 16, 2018

Proposed fix is pushed, @KatieWoe can you please test and verify?

@KatieWoe
Copy link
Contributor Author

This seems fixed on master

@KatieWoe KatieWoe reopened this Jan 23, 2019
@KatieWoe
Copy link
Contributor Author

For phetsims/qa#264 I noticed this when dragging the end of the measure, rather than the measure itself. It also catches the timer and wave examiner.

@samreid
Copy link
Member

samreid commented Jan 23, 2019

Good catch @KatieWoe, fix is pushed, can you please verify on phettest/master?

@KatieWoe
Copy link
Contributor Author

Looks good on master @samreid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants