Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning to a scene after reset all causes a flash #233

Closed
KatieWoe opened this issue Dec 12, 2018 · 4 comments
Closed

Returning to a scene after reset all causes a flash #233

KatieWoe opened this issue Dec 12, 2018 · 4 comments

Comments

@KatieWoe
Copy link
Contributor

Test device:
Dell Laptop
Operating System:
Win 10
Browser:
chrome
Problem description:
For phetsims/qa#238
When running a wave on a scene other than water in the Waves or Interference screen, hitting the reset all button and then returning to the scene will leave a brief flash of the old state. A similar visual glitch seems to happen when a water wave is happening in side view and reset all is hit, but the flash of wave happens as soon as everything is reset.
Steps to reproduce:

  1. Go to the Wave or Interference screen
  2. Select the light scene (color makes it easier to see)
  3. Start a continuous wave
  4. While wave is going, hit Reset All button
  5. Navigate back to the light scene

Screenshots:
For some reason this does not seem to show up on the screen recorder

Troubleshooting information (do not edit):

Name: ‪Wave Interference‬
URL: https://phet-dev.colorado.edu/html/wave-interference/1.0.0-dev.51/phet/wave-interference_en_phet.html
Version: 1.0.0-dev.51 2018-12-12 03:47:24 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36
Language: en-US
Window: 1536x732
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"928741cf","branch":"master"},"axon":{"sha":"73e761ec","branch":"master"},"brand":{"sha":"1fd6682e","branch":"master"},"chipper":{"sha":"61bc739b","branch":"master"},"dot":{"sha":"b45eafe8","branch":"master"},"griddle":{"sha":"914c9215","branch":"master"},"joist":{"sha":"5a013a46","branch":"master"},"kite":{"sha":"f3e96e5b","branch":"master"},"phet-core":{"sha":"86dec8cc","branch":"master"},"phet-io":{"sha":"a267fdb1","branch":"master"},"phet-io-wrapper-classroom-activity":{"sha":"5dea7f54","branch":"master"},"phet-io-wrapper-hookes-law-energy":{"sha":"b42eaef7","branch":"master"},"phet-io-wrapper-lab-book":{"sha":"b884e9c1","branch":"master"},"phet-io-wrappers":{"sha":"d5b42848","branch":"master"},"phetcommon":{"sha":"869b2561","branch":"master"},"query-string-machine":{"sha":"e4f9e8e8","branch":"master"},"scenery":{"sha":"a18ce7f1","branch":"master"},"scenery-phet":{"sha":"56df5b6d","branch":"master"},"sherpa":{"sha":"a1f5e867","branch":"master"},"sun":{"sha":"38ed71af","branch":"master"},"tambo":{"sha":"746fbd32","branch":"master"},"tandem":{"sha":"c7a56e2e","branch":"master"},"twixt":{"sha":"e38c70ed","branch":"master"},"wave-interference":{"sha":"bfce593d","branch":"master"}}

@samreid
Copy link
Member

samreid commented Dec 12, 2018

This does not occur on my Mac Chrome (or is nearly instant), but I can see it in my Mac Firefox.

@samreid
Copy link
Member

samreid commented Dec 12, 2018

Pushed fix, @KatieWoe can you please verify on phettest?

@KatieWoe
Copy link
Contributor Author

Looks good on master.

@samreid samreid closed this as completed Dec 12, 2018
@samreid
Copy link
Member

samreid commented Dec 12, 2018

Marked closed so it will show up in red on the QA issue. We can verify if in the next dev release if desired.

samreid added a commit to phetsims/scenery-phet that referenced this issue Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants