Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset all not resetting "two slits" back to "one slit" #183

Closed
samreid opened this issue Oct 26, 2018 · 5 comments
Closed

Reset all not resetting "two slits" back to "one slit" #183

samreid opened this issue Oct 26, 2018 · 5 comments
Assignees
@arouinfar @KatieWoe
Labels
status:ready-for-review type:bug

Comments

@samreid
Copy link
Member

samreid commented Oct 26, 2018

No description provided.

@samreid samreid self-assigned this Oct 26, 2018
samreid added a commit that referenced this issue Oct 30, 2018
@samreid
reset the barrier state on reset all, see #183
f7ea0e2
@samreid
Copy link
Member Author

samreid commented Oct 30, 2018

Proposed fix pushed, @arouinfar can you please test?

@samreid samreid assigned arouinfar and unassigned samreid Oct 30, 2018
@arouinfar
Copy link
Contributor

Looks good @samreid.

@KatieWoe KatieWoe reopened this Dec 13, 2018
@KatieWoe
Copy link
Contributor

For phetsims/qa#238. This issue is occurring. It also does not turn No Barrier into one slit. This applies to all scenes on the screen and all browsers tested so far. It does reset any size changes made. @samreid

samreid added a commit that referenced this issue Dec 14, 2018
@samreid
Reset barrier type selection, see #183
20cdf60
@samreid
Copy link
Member Author

samreid commented Dec 14, 2018

Proposed fix pushed, @KatieWoe can you please verify on phettest?

@samreid samreid assigned KatieWoe and unassigned samreid Dec 14, 2018
@KatieWoe
Copy link
Contributor

Looks good on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

@KatieWoe KatieWoe

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @arouinfar @KatieWoe