Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the Announcer and UtteranceQueue both have an enabledProperty? #62

Open
jessegreenberg opened this issue Feb 16, 2022 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

In #58 @zepumph said

Basically here are the control Properties that we have to keep track of:
UtteranceQueue.muted
UtteranceQueue.enabledProperty
SpeechSynthesisAnnouncer.enabledProperty
SpeechSynthesisAnnouncer.canSpeakProperty
With joist (thus our sims) kinda taking its pick as to what to set during different things, it is really hard for me to see the full picture, and thus what could be the best and simplest implementation. It is a work in progress, and one that relates to our conversation from a Friday past about creating a preferences model. Do you feel this tension, or am I overreacting? (those are your only two options. . . . )

I said

I did not feel the tension but see it now that you mention it. I don't think this relates to to canSpeakProperty (A private DerivedProperty) but I see it as confusing that we have an enabledProperty on both the UtteranceQueue and the Announcer. I could see us making the enabledProperty of the Announcer utterance-queueu internal.

It seems to me that all should go through the utteranceQueue. If the Announcer is disabled, that should be utterance-queue internal.

@jessegreenberg jessegreenberg self-assigned this Feb 16, 2022
@zepumph zepumph self-assigned this Apr 1, 2022
@zepumph
Copy link
Member

zepumph commented Apr 15, 2022

@jessegreenberg and I discussed this today. We can see a world where SpeechSynthesisAnnouncer's enabled Property doesn't control voicing, but a separate Joist Property does (like for the toolbar). Then most everything can be controlled by the utterance queue. And perhaps the canSpeakProperty can just change the announcer's enabled.

We don't want to work on this though until we do phetsims/scenery#1343. On hold.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants