Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: Utterance: alertMaximumDelay tests failed #115

Open
jessegreenberg opened this issue Oct 5, 2023 · 7 comments
Open

CT: Utterance: alertMaximumDelay tests failed #115

jessegreenberg opened this issue Oct 5, 2023 · 7 comments

Comments

@jessegreenberg
Copy link
Contributor

This is intermittent on CT, occurs somewhat rarely.

image

Ill see if I can pin it down.

@jessegreenberg jessegreenberg self-assigned this Oct 5, 2023
@jessegreenberg
Copy link
Contributor Author

It seems to mostly fail when the phet-io query parameter is used.

image

@jessegreenberg jessegreenberg changed the title CT: Utterance: alertMaximumDelay tests failed: CT: Utterance: alertMaximumDelay tests failed Oct 5, 2023
@jessegreenberg
Copy link
Contributor Author

Running the tests in isolation, the UtteranceQueue is not initialized. I don't think that is the problem on CT because only the last test is failing from "lertMaximumDelay tests". But I am not sure.

  await timeout( 150 );
  assert.ok( utteranceQueue[ 'queue' ].length === 0, 'not stable, but past max' );

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Oct 11, 2023

The UtteranceQueue tests are hitting the announceImmediately, which is necessary for browser compatibility on the first utterance. But is is messing with the expectations of the UtteranceQueue timing tests. Ill disable that for these tests and see if that fixes it on CT.

The failures are intermittent.
image

If we can get ~10 columns passing Ill close this.

@jessegreenberg
Copy link
Contributor Author

I am pretty sure that this is fixed and allowed #116 to come through. Closing.

@jessegreenberg
Copy link
Contributor Author

Unfortunately I still see this one at SHA fec40dc on CT.

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 22, 2023

This is still occurring in CT on 12/21/23 and 12/22/23. I would not call this intermittent - it occurs in 3 of the 10 more recent cycles.

100% of the failures that I currently see are in top-level-unit-tests, for example see below. This also makes me wonder how useful these unit tests are if they are not reproducible on every run.

utterance-queue : top-level-unit-tests : unbuilt?ea
http://128.138.93.172/continuous-testing/ct-snapshots/1703258473895/utterance-queue/utterance-queue-tests.html?ea
7 out of 8 tests passed. 1 failed.
Utterance: announceImmediately failed:
myUtterance announced immediately when Announcer was ready["This is my utterance text"]
at Object.<anonymous> (http://128.138.93.172/continuous-testing/ct-snapshots/1703258473895/chipper/dist/js/utterance-queue/js/UtteranceTests.js:176:10)

[URL] http://128.138.93.172/continuous-testing/aqua/html/qunit-test.html?url=..%2F..%2Fct-snapshots%2F1703258473895%2Futterance-queue%2Futterance-queue-tests.html%3Fea&testInfo=%7B%22test%22%3A%5B%22utterance-queue%22%2C%22top-level-unit-tests%22%2C%22unbuilt%3Fea%22%5D%2C%22snapshotName%22%3A%22snapshot-1703258473895%22%2C%22timestamp%22%3A1703258947951%7D
[NAVIGATED] http://128.138.93.172/continuous-testing/aqua/html/qunit-test.html?url=..%2F..%2Fct-snapshots%2F1703258473895%2Futterance-queue%2Futterance-queue-tests.html%3Fea&testInfo=%7B%22test%22%3A%5B%22utterance-queue%22%2C%22top-level-unit-tests%22%2C%22unbuilt%3Fea%22%5D%2C%22snapshotName%22%3A%22snapshot-1703258473895%22%2C%22timestamp%22%3A1703258947951%7D
[NAVIGATED] about:blank
[NAVIGATED] http://128.138.93.172/continuous-testing/ct-snapshots/1703258473895/utterance-queue/utterance-queue-tests.html?ea
[CONSOLE] Failed to load resource: the server responded with a status of 404 (Not Found): http://128.138.93.172/continuous-testing/ct-snapshots/1703258473895/utterance-queue/utterance-queue-strings_en.json
[CONSOLE] enabling assert

id: "Sparky Node Puppeteer"
Snapshot from 12/22/2023, 8:21:13 AM

@jessegreenberg
Copy link
Contributor Author

Unfortunately, they only fail on CT/puppeteer and I have not been able to figure out why. One more shot in the above commit that is always passing locally but if its still no good on CT Ill probably remove these timing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants