Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Dialog's CloseButton to use scenery-phet's CloseButton #486

Open
zepumph opened this issue Mar 6, 2019 · 4 comments
Open

Convert Dialog's CloseButton to use scenery-phet's CloseButton #486

zepumph opened this issue Mar 6, 2019 · 4 comments
Assignees
@jessegreenberg
Labels
type:misc

Comments

@zepumph
Copy link
Member

zepumph commented Mar 6, 2019

From #437:

I think function CloseButton( options ) { should be deleted and replaced with usage of scenery-phet/js/buttons/CloseButton.js. If you agree, let's open a new issue for that.

I agree!
@zepumph zepumph mentioned this issue Mar 6, 2019
Closed
@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2019

@samreid you had recommended this back in #437, but do you still feel this way knowing that this would add a dependency from sun to SCENERY_PHET/CloseButton?

@zepumph zepumph removed their assignment Oct 17, 2019
@samreid
Copy link
Member

samreid commented Oct 17, 2019

Perhaps CloseButton belongs in sun?

@samreid samreid removed their assignment Jun 11, 2020
@zepumph
Copy link
Member Author

zepumph commented Mar 3, 2023

Looks like this was done in 2138636.

@jessegreenberg, this puts a dependency from sun on scenery-phet. Do you have a recommendation about that?

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Mar 3, 2023
@samreid
Copy link
Member

samreid commented Mar 5, 2023

Clarifying... including this occurrence, sun now has 6 dependencies (6 imports) from scenery-phet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
type:misc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @jessegreenberg @zepumph