diff --git a/tatus b/tatus deleted file mode 100644 index 2f98369c..00000000 --- a/tatus +++ /dev/null @@ -1,53 +0,0 @@ -diff --git a/js/ComboBox.ts b/js/ComboBox.ts -index bb6e2405..19523899 100644 ---- a/js/ComboBox.ts -+++ b/js/ComboBox.ts -@@ -134,6 +134,12 @@ type SelfOptions = { - openedSoundPlayer?: TSoundPlayer; - closedNoChangeSoundPlayer?: TSoundPlayer; -  -+ // pdom -+ // The tag name for the label of the ComboBox. The AccessibleNameBehavior forwards the name to the ComboBoxButton, -+ // so if you need a different tag name for the ComboBox, set it here. See the ACCESSIBLE_NAME_BEHAVIOR functions -+ // for ComboBox and ComboBoxButton. -+ buttonLabelTagName?: string; -+ - // Voicing - // ComboBox does not mix Voicing, so it creates custom options to pass to composed Voicing Nodes. - // The pattern for the name response string, must include `{{value}}` so that the selected value string can -@@ -235,6 +241,7 @@ export default class ComboBox extends WidthSizable( Node ) { -  - // pdom - tagName: 'div', // must have accessible content to support behavior functions -+ buttonLabelTagName: 'p', - accessibleNameBehavior: ACCESSIBLE_NAME_BEHAVIOR, - helpTextBehavior: HELP_TEXT_BEHAVIOR, -  -@@ -294,6 +301,7 @@ export default class ComboBox extends WidthSizable( Node ) { - comboBoxVoicingNameResponsePattern: options.comboBoxVoicingNameResponsePattern, -  - // pdom - accessibleName and helpText are set via behavior functions on the ComboBox -+ labelTagName: options.buttonLabelTagName, -  - // phet-io - tandem: options.tandem.createTandem( 'button' ) -diff --git a/js/ComboBoxButton.ts b/js/ComboBoxButton.ts -index 24124f32..7f267692 100644 ---- a/js/ComboBoxButton.ts -+++ b/js/ComboBoxButton.ts -@@ -37,7 +37,6 @@ export type ComboBoxButtonArrowDirection = typeof ARROW_DIRECTION_VALUES[number] - // The definition for how ComboBoxButton sets its accessibleName in the PDOM. See ComboBox.md for further style guide - // and documentation on the pattern. - const ACCESSIBLE_NAME_BEHAVIOR: PDOMBehaviorFunction = ( node, options, accessibleName ) => { -- options.labelTagName = 'p'; // NOTE: A `span` causes duplicate name-speaking with VO+safari in https://github.com/phetsims/ratio-and-proportion/issues/532 - options.labelContent = accessibleName; - return options; - }; -@@ -105,6 +104,7 @@ export default class ComboBoxButton extends RectangularPushButton { -  - // pdom - containerTagName: 'div', -+ labelTagName: 'p', // NOTE: A `span` causes duplicate name-speaking with VO+safari in https://github.com/phetsims/ratio-and-proportion/issues/532 - accessibleNameBehavior: ACCESSIBLE_NAME_BEHAVIOR - }, providedOptions ); -