Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the PDOM from Display.foreignObjectRasterization() image #1263

Closed
zepumph opened this issue Aug 7, 2021 · 2 comments
Closed

Hide the PDOM from Display.foreignObjectRasterization() image #1263

zepumph opened this issue Aug 7, 2021 · 2 comments
Assignees
@jonathanolson
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Aug 7, 2021

I discovered this while testing changes made in phetsims/utterance-queue#13 with the snapshot comparison which is now set up to test PDOM changes (since work in phetsims/aqua#127). I noticed that the image looks something like this:

image
@zepumph zepumph self-assigned this Aug 7, 2021
zepumph added a commit that referenced this issue Aug 7, 2021
@zepumph
hide the PDOM from Display.foreignObjectRasterization, #1263
95e9524
@zepumph
Copy link
Member Author

zepumph commented Aug 7, 2021

Here is what things look like now that I fixed it:

image

@jonathanolson can you please review. Feel free to close.

@zepumph zepumph assigned jonathanolson and unassigned zepumph Aug 7, 2021
@jonathanolson
Copy link
Contributor

Looks great to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @zepumph