Skip to content

Commit 63780ed

Browse files
authored
code markdown
1 parent 9f13ad7 commit 63780ed

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

checklists/code_review_checklist.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ addListener: function( listener ) { /*...*/ }
481481
- [ ] Is there anything that should be generalized and migrated to common code?
482482
- [ ] Are there any `TODO` or `FIXME` comments in the code? They should be addressed or promoted to GitHub issues.
483483
- [ ] Are there any [magic numbers](https://en.wikipedia.org/wiki/Magic_number_(programming)) that should be factored out as constants and documented?
484-
- [ ] Are there any constants that are duplicated in multiple files that should be factored out into a {{REPO}}Constants.js file?
484+
- [ ] Are there any constants that are duplicated in multiple files that should be factored out into a `{{REPO}}Constants.js` file?
485485
- [ ] Is [PhetColorScheme](https://github.com/phetsims/scenery-phet/blob/master/js/PhetColorScheme.js) used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in `PhetColorScheme`. Identify any colors that might be worth adding to `PhetColorScheme`.
486486
- [ ] Does the implementation rely on any specific constant values that are likely to change in the future? Identify constants that might be changed in the future. (Use your judgement about which constants are likely candidates.) Does changing the values of these constants break the sim? For example, see https://github.com/phetsims/plinko-probability/issues/84.
487487
- [ ] Are all dependent properties modeled as `DerivedProperty` instead of `Property`?

0 commit comments

Comments
 (0)