Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'grunt create-sim' sets repo URL for new sim to "https://github.com/phetsims/<new sim name>.git" #360

Open
fgamador opened this issue Jul 15, 2024 · 0 comments

Comments

@fgamador
Copy link

I ran this (on Windows):

C:\Users\franz\Dev\NodeProjects\phetsims\perennial (main -> origin) ([email protected])
λ grunt create-sim --repo=my-first-sim --author="Franz Amador"

and found this in my-first-sim_en.html. My new sim doesn't even have a git url until I create its repo, and it won't be in phetsims. I'm guessing this setting isn't used for anything important, so this probably isn't a big deal, but it doesn't seem right.

window.phet.chipper.packageObject =
{
[...]
"repository": {
"type": "git",
"url": "https://github.com/phetsims/my-first-sim.git"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants