From 6bc4832cd1e4022f4bd51d0905e34f2c1767c5ff Mon Sep 17 00:00:00 2001 From: zepumph Date: Mon, 16 Mar 2020 15:56:45 -0800 Subject: [PATCH] update TODO issue links, https://github.com/phetsims/perennial/issues/166 https://github.com/phetsims/perennial/issues/138 --- js/grunt/PDOMComparison.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/js/grunt/PDOMComparison.js b/js/grunt/PDOMComparison.js index cabc992f..54fbeec3 100644 --- a/js/grunt/PDOMComparison.js +++ b/js/grunt/PDOMComparison.js @@ -76,7 +76,7 @@ module.exports = async ( repo, sha ) => { const diff = htmlDiffer.diffHtml( workingCopyPDOM, oldShaPDOM ); - // TODO https://github.com/phetsims/perennial/issues/166 better interpretation of the diff that is output. Perhaps by looking at "diff" more manually, see https://www.npmjs.com/package/html-differ + // TODO https://github.com/phetsims/perennial/issues/138 better interpretation of the diff that is output. Perhaps by looking at "diff" more manually, see https://www.npmjs.com/package/html-differ console.log( logger.getDiffText( diff, { charsAroundDiff: 40 } ) ); }; @@ -139,8 +139,8 @@ const stashAll = async repos => { /** * Launch a chrome version, run the simulation, and get the PDOM from the simulation. - * TODO https://github.com/phetsims/perennial/issues/166 add in functions that can be executed to change the model in between tests. - * TODO https://github.com/phetsims/perennial/issues/166 maybe we could fuzz a few frames, and then test while setting the random seed to be the same for all pages + * TODO https://github.com/phetsims/perennial/issues/138 add in functions that can be executed to change the model in between tests. + * TODO https://github.com/phetsims/perennial/issues/138 maybe we could fuzz a few frames, and then test while setting the random seed to be the same for all pages * @param repo * @returns {Promise} */ @@ -165,7 +165,7 @@ const launchSimAndGetPDOMText = async repo => { const pdoms = await page.evaluate( () => { return new Promise( function( resolve, reject ) { - // TODO https://github.com/phetsims/perennial/issues/166 + // TODO https://github.com/phetsims/perennial/issues/138 // window.phet.sim.joist.frameEndedEmitter.addListener(); window.addEventListener( 'message', function( event ) {