Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight artifacts on escaping and spinning NO2 and O3 molecules #122

Open
phet-steele opened this issue Aug 20, 2015 · 11 comments
Open

Slight artifacts on escaping and spinning NO2 and O3 molecules #122

phet-steele opened this issue Aug 20, 2015 · 11 comments

Comments

@phet-steele
Copy link
Contributor

While testing 1.1.0-rc.1 in FF 40 (Win 8.1), I saw ever so slight artifacts being left behind after movement of NO2 and O3 molecules.

tiny artifacts

Name: ‪Molecules and Light‬
URL: http://www.colorado.edu/physics/phet/dev/html/molecules-and-light/1.1.0-rc.1/molecules-and-light_en.html
Version: 1.1.0-rc.1 2015-08-11 18:49:22 UTC
Features missing: touch
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Language: en-US
Window: 1366x633
Pixel Ratio: 1/1
WebGL: WebGL 1.0
GLSL: WebGL GLSL ES 1.0
Vendor: Mozilla (Mozilla)
Vertex: attribs: 16 varying: 28 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"858e65ac","branch":"master"},"axon":{"sha":"1f0ca9f4","branch":"master"},"babel":{"sha":"2431e711","branch":"master"},"brand":{"sha":"aa39bc48","branch":"master"},"chipper":{"sha":"6cb12b9c","branch":"master"},"dot":{"sha":"e34c6b2c","branch":"master"},"joist":{"sha":"77298536","branch":"master"},"kite":{"sha":"24978146","branch":"master"},"molecules-and-light":{"sha":"05c075b5","branch":"1.1"},"nitroglycerin":{"sha":"c6f79ce4","branch":"master"},"phet-core":{"sha":"8e31808c","branch":"master"},"phetcommon":{"sha":"89a44d2c","branch":"master"},"scenery":{"sha":"e23c0f08","branch":"master"},"scenery-phet":{"sha":"bec2cc7f","branch":"master"},"sherpa":{"sha":"4f160877","branch":"master"},"sun":{"sha":"66c091cc","branch":"master"}}

@jessegreenberg
Copy link
Contributor

Unable to reproduce on Windows 7 FF 40.0.2, but to be honest I can't really see any artifacts in the image above.

@jessegreenberg
Copy link
Contributor

Ah, when I blow up the image, I can see very small green dots in between the two ultraviolet photons, @phet-steele is this what you are referring to?

@phet-steele
Copy link
Contributor Author

Yea, they travel all the way up the screen, too. They are small, sure, but pretty obvious on my screen.

@phet-steele
Copy link
Contributor Author

l'll update FF and see what happens.

@phet-steele
Copy link
Contributor Author

Still there.

@ariel-phet
Copy link

@jessegreenberg you can mark this as will not fix for the moment, but leave this as an open issue.

@jbphet
Copy link
Contributor

jbphet commented Aug 24, 2015

@jonathanolson - I thought you might want to take a quick look at this and see if it is anything to be concerned about in Scenery. If there is nothing obvious, please assign back to me.

@jbphet
Copy link
Contributor

jbphet commented Aug 24, 2015

Not needed for the upcoming release.

@jonathanolson
Copy link
Contributor

Looks like a Firefox-specific SVG rendering bug.

A potential fix would be to have at least 1px of transparency along the borders of the image (it looks like the semi-transparent content goes all the way to the edge of the image). Don't have a good idea of how likely this would be to fix it.

@jessegreenberg
Copy link
Contributor

I was just able to reproduce this. It is so hard to see I think I missed it the first time
tracers

Leaving as open issue, but not to be fixed for this release.

@jbphet
Copy link
Contributor

jbphet commented Aug 25, 2015

Since we're not going to try to address it for the next release, I will unassign the issue until we decide to close or address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants